Support for |change| argument to |GetPreferredTrySlaves()|, try 2.

Support for |change| argument to |GetPreferredTrySlaves()|, try 2.

Needed to make it so changes containing only *.mm are only sent to Mac trybots by default.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102930

[Alexei Svitkine (slow), 2011-09-27 13:50:39]

Marc-Antoine, can you take another look?

I've updated this with a couple of fixes.

The first is to fix the lazy-load logic. I've made it differentiate between None
and [] that may have been loaded from the SCM.

The second is to |TryChange()| in gcl.py to set change=None when there's no
|change_info|, so that |trychange.TryChange()| will fill in the details in that
case.

[Alexei Svitkine (slow), 2011-09-27 13:56:20]

Also, can you check if there were any other error stacks than those two, to make
sure I didn't missing another problem?

[M-A Ruel, 2011-09-27 14:13:00]

lgtm with nit but wait for http://codereview.chromium.org/8056005 to be
committed first.

http://codereview.chromium.org/8059009/diff/1/trychange.py
File trychange.py (right):

http://codereview.chromium.org/8059009/diff/1/trychange.py#newcode106
trychange.py:106: if self.options.files != []:
if self.options.files:
?

[Alexei Svitkine (slow), 2011-09-27 14:21:01]

I've uploaded an updated version that now specifies the correct file paths on
the change when using -R (i.e. it gets them from the patch, rather than whatever
you have changed in your local repo).

Can you take another glance?

http://codereview.chromium.org/8059009/diff/1/trychange.py
File trychange.py (right):

http://codereview.chromium.org/8059009/diff/1/trychange.py#newcode106
trychange.py:106: if self.options.files != []:
On 2011/09/27 14:13:00, Marc-Antoine Ruel wrote:
> if self.options.files:
> ?

Done.

[M-A Ruel, 2011-09-27 14:23:00]

lgtm

[commit-bot: I haz the power, 2011-09-27 14:25:04]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8059009/8002

[commit-bot: I haz the power, 2011-09-27 14:30:57]

Change committed as 102930

[M-A Ruel, 2011-09-30 15:38:44]

http://codereview.chromium.org/8059009/diff/8002/trychange.py
File trychange.py (right):

http://codereview.chromium.org/8059009/diff/8002/trychange.py#newcode488
trychange.py:488: file_list,
I just realized this was an error. TryChange should accept one of change or
file_list, not both. So in that case, file_list should be removed entirely. This
is confusing otherwise.