ppapi/native_client/tests/ppapi_browser/bad/nacl.scons - Issue 8056008: Disable ppapi_bad test for glibc on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/tests/ppapi_browser/bad/nacl.scons

Issue 8056008: Disable ppapi_bad test for glibc on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix parens Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/native_client/tests/ppapi_browser/bad/nacl.scons

diff --git a/ppapi/native_client/tests/ppapi_browser/bad/nacl.scons b/ppapi/native_client/tests/ppapi_browser/bad/nacl.scons

index 36da0ab2fe6d382dace522edca40be635bd52638..1fa87150fd8d685de9e81264e568563db25558c8 100644

--- a/ppapi/native_client/tests/ppapi_browser/bad/nacl.scons

+++ b/ppapi/native_client/tests/ppapi_browser/bad/nacl.scons

@@ -68,7 +68,8 @@ node = env.PPAPIBrowserTester(

env.AddNodeToTestSuite(node,

['chrome_browser_tests'],

'run_ppapi_bad_browser_test',

- is_broken=env.PPAPIBrowserTesterIsBroken())

+ is_broken=env.PPAPIBrowserTesterIsBroken() or

+ (env.Bit('nacl_glibc') and env.Bit('windows')))

Nick Bray 2011/09/27 17:05:42 Please stick a comment in the code linking to the

# Bad nexe tests that won't work in PNaCl (native)

« no previous file with comments | « no previous file | no next file » | no next file with comments »