src/ia32/ic-ia32.cc - Issue 8054043: Porting r9456 to x64 (Optimize KeyedStoreGeneric for Smi arrays).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/ic-ia32.cc

Issue 8054043: Porting r9456 to x64 (Optimize KeyedStoreGeneric for Smi arrays). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: SSE2 instruction for int2double conversion. Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/ic-ia32.cc

diff --git a/src/ia32/ic-ia32.cc b/src/ia32/ic-ia32.cc

index 3c95356642b42a2d90c6a1ec1e9679e870bb1580..a7c9ee8d0f52483e935d72c38f84d8fff6a00582 100644

--- a/src/ia32/ic-ia32.cc

+++ b/src/ia32/ic-ia32.cc

@@ -765,7 +765,7 @@ void KeyedStoreIC::GenerateGeneric(MacroAssembler* masm,

// ecx: key (a smi)

// edi: receiver map

__ mov(ebx, FieldOperand(edx, JSObject::kElementsOffset));

- // Check that the object is in fast mode and writable.

+ // Check array bounds. Both the key and the length of FixedArray are smis.

__ cmp(ecx, FieldOperand(ebx, FixedArray::kLengthOffset));

__ j(below, &fast_object_with_map_check);

« no previous file with comments | « no previous file | src/x64/ic-x64.cc » ('j') | src/x64/ic-x64.cc » ('J')