Recover from bad proxy settings pointing to non-proxy servers that reply anyway.

chrome/browser/policy/device_management_service_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <ostream>
 #include <vector>
 
 #include "base/message_loop.h"
 #include "base/string_split.h"
 #include "chrome/browser/policy/device_management_backend_impl.h"
 #include "chrome/browser/policy/device_management_backend_mock.h"
 #include "chrome/browser/policy/device_management_service.h"
 #include "chrome/browser/policy/proto/device_management_constants.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "content/browser/browser_thread.h"
 #include "content/test/test_url_fetcher_factory.h"
 #include "net/base/escape.h"
+#include "net/base/load_flags.h"
+#include "net/base/net_errors.h"
+#include "net/http/http_response_headers.h"
 #include "net/url_request/url_request_status.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::IgnoreResult;
 using testing::InvokeWithoutArgs;
+using testing::Mock;
+using testing::StrictMock;
 using testing::_;
 
 namespace policy {
 
 const char kServiceUrl[] = "https://example.com/management_service";
 
 // Encoded empty response messages for testing the error code paths.
 const char kResponseEmpty[] = "\x08\x00";
 
 #define PROTO_STRING(name) (std::string(name, arraysize(name) - 1))
@@ skipping 479 matching lines @@
                                           GURL(kServiceUrl),
                                           status,
                                           500,
                                           net::ResponseCookies(),
                                           "");
 
   // Backend should have been reset.
   EXPECT_FALSE(backend_.get());
 }
 
+TEST_F(DeviceManagementServiceTest, RetryOnProxyError) {
+  // Make a request.
+  StrictMock<DeviceRegisterResponseDelegateMock> mock;
+
+  em::DeviceRegisterRequest request;
+  backend_->ProcessRegisterRequest(kGaiaAuthToken, kOAuthToken,
+                                   kDeviceId, request, &mock);
+  TestURLFetcher* fetcher = factory_.GetFetcherByID(0);
+  ASSERT_TRUE(fetcher);
+  EXPECT_TRUE((fetcher->load_flags() & net::LOAD_BYPASS_PROXY) == 0);
+  const GURL original_url(fetcher->original_url());
+  const std::string upload_data(fetcher->upload_data());
+
+  // Generate a callback with a proxy failure.
+  net::URLRequestStatus status(net::URLRequestStatus::FAILED,
+                               net::ERR_PROXY_CONNECTION_FAILED);
+  fetcher->delegate()->OnURLFetchComplete(fetcher,
+                                          GURL(kServiceUrl),
+                                          status,
+                                          0,
+                                          net::ResponseCookies(),
+                                          "");
+
+  // Verify that a new URLFetcher was started that bypasses the proxy.
+  fetcher = factory_.GetFetcherByID(0);
+  ASSERT_TRUE(fetcher);
+  EXPECT_TRUE((fetcher->load_flags() & net::LOAD_BYPASS_PROXY) != 0);

[Mattias Nissler (ping if slow), 2011/09/28 09:06:18]

you can drop the != 0

[Joao da Silva, 2011/09/28 19:20:27]

Done.

+  EXPECT_EQ(original_url, fetcher->original_url());
+  EXPECT_EQ(upload_data, fetcher->upload_data());
+
+  // No calls should have been made to the mock.

[Mattias Nissler (ping if slow), 2011/09/28 09:06:18]

Other code uses EXPECT_CALL().Times(0) instead of StrictMock to achieve this,
and the gmock documentation advises against using StrictMock if you can achieve
what you want with regular mocks and expectations.

[Joao da Silva, 2011/09/28 19:20:27]

Done.

+  Mock::VerifyAndClearExpectations(&mock);
+}
+
+TEST_F(DeviceManagementServiceTest, RetryOnBadResponseFromProxy) {
+  // Make a request.
+  StrictMock<DeviceRegisterResponseDelegateMock> mock;
+
+  em::DeviceRegisterRequest request;
+  backend_->ProcessRegisterRequest(kGaiaAuthToken, kOAuthToken,
+                                   kDeviceId, request, &mock);
+  TestURLFetcher* fetcher = factory_.GetFetcherByID(0);
+  ASSERT_TRUE(fetcher);
+  EXPECT_TRUE((fetcher->load_flags() & net::LOAD_BYPASS_PROXY) == 0);
+  const GURL original_url(fetcher->original_url());
+  const std::string upload_data(fetcher->upload_data());
+  fetcher->set_was_fetched_via_proxy(true);
+  scoped_refptr<net::HttpResponseHeaders> headers;
+  headers = new net::HttpResponseHeaders(
+      "HTTP/1.1 200 OK\0Content-type: bad/type\0\0");
+  fetcher->set_response_headers(headers);
+
+  // Generate a callback with a valid http response, that was generated by
+  // a bad/wrong proxy.
+  net::URLRequestStatus status;
+  fetcher->delegate()->OnURLFetchComplete(fetcher,
+                                          GURL(kServiceUrl),
+                                          status,
+                                          200,
+                                          net::ResponseCookies(),
+                                          "");
+
+  // Verify that a new URLFetcher was started that bypasses the proxy.
+  fetcher = factory_.GetFetcherByID(0);
+  ASSERT_TRUE(fetcher);
+  EXPECT_TRUE((fetcher->load_flags() & net::LOAD_BYPASS_PROXY) != 0);
+  EXPECT_EQ(original_url, fetcher->original_url());
+  EXPECT_EQ(upload_data, fetcher->upload_data());
+
+  // No calls should have been made to the mock.
+  Mock::VerifyAndClearExpectations(&mock);
+}
+
 }  // namespace policy