Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 8054008: Improve our simple elimination of hole checks. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1704 matching lines...) Expand 10 before | Expand all | Expand 10 after
1715 return DefineAsRegister(new LConstantT); 1715 return DefineAsRegister(new LConstantT);
1716 } else { 1716 } else {
1717 UNREACHABLE(); 1717 UNREACHABLE();
1718 return NULL; 1718 return NULL;
1719 } 1719 }
1720 } 1720 }
1721 1721
1722 1722
1723 LInstruction* LChunkBuilder::DoLoadGlobalCell(HLoadGlobalCell* instr) { 1723 LInstruction* LChunkBuilder::DoLoadGlobalCell(HLoadGlobalCell* instr) {
1724 LLoadGlobalCell* result = new LLoadGlobalCell; 1724 LLoadGlobalCell* result = new LLoadGlobalCell;
1725 return instr->check_hole_value() 1725 return instr->RequiresHoleCheck()
1726 ? AssignEnvironment(DefineAsRegister(result)) 1726 ? AssignEnvironment(DefineAsRegister(result))
1727 : DefineAsRegister(result); 1727 : DefineAsRegister(result);
1728 } 1728 }
1729 1729
1730 1730
1731 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) { 1731 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) {
1732 LOperand* global_object = UseFixed(instr->global_object(), rax); 1732 LOperand* global_object = UseFixed(instr->global_object(), rax);
1733 LLoadGlobalGeneric* result = new LLoadGlobalGeneric(global_object); 1733 LLoadGlobalGeneric* result = new LLoadGlobalGeneric(global_object);
1734 return MarkAsCall(DefineFixed(result, rax), instr); 1734 return MarkAsCall(DefineFixed(result, rax), instr);
1735 } 1735 }
1736 1736
1737 1737
1738 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) { 1738 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) {
1739 LStoreGlobalCell* result = 1739 LStoreGlobalCell* result =
1740 new LStoreGlobalCell(UseTempRegister(instr->value()), 1740 new LStoreGlobalCell(UseTempRegister(instr->value()),
1741 TempRegister(), 1741 TempRegister(),
1742 TempRegister()); 1742 TempRegister());
1743 return instr->check_hole_value() ? AssignEnvironment(result) : result; 1743 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result;
1744 } 1744 }
1745 1745
1746 1746
1747 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) { 1747 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) {
1748 LOperand* global_object = UseFixed(instr->global_object(), rdx); 1748 LOperand* global_object = UseFixed(instr->global_object(), rdx);
1749 LOperand* value = UseFixed(instr->value(), rax); 1749 LOperand* value = UseFixed(instr->value(), rax);
1750 LStoreGlobalGeneric* result = new LStoreGlobalGeneric(global_object, value); 1750 LStoreGlobalGeneric* result = new LStoreGlobalGeneric(global_object, value);
1751 return MarkAsCall(result, instr); 1751 return MarkAsCall(result, instr);
1752 } 1752 }
1753 1753
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
2177 LOperand* key = UseOrConstantAtStart(instr->key()); 2177 LOperand* key = UseOrConstantAtStart(instr->key());
2178 LOperand* object = UseOrConstantAtStart(instr->object()); 2178 LOperand* object = UseOrConstantAtStart(instr->object());
2179 LIn* result = new LIn(key, object); 2179 LIn* result = new LIn(key, object);
2180 return MarkAsCall(DefineFixed(result, rax), instr); 2180 return MarkAsCall(DefineFixed(result, rax), instr);
2181 } 2181 }
2182 2182
2183 2183
2184 } } // namespace v8::internal 2184 } } // namespace v8::internal
2185 2185
2186 #endif // V8_TARGET_ARCH_X64 2186 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698