Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 8054008: Improve our simple elimination of hole checks. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1761 matching lines...) Expand 10 before | Expand all | Expand 10 after
1772 return DefineAsRegister(new LConstantT); 1772 return DefineAsRegister(new LConstantT);
1773 } else { 1773 } else {
1774 UNREACHABLE(); 1774 UNREACHABLE();
1775 return NULL; 1775 return NULL;
1776 } 1776 }
1777 } 1777 }
1778 1778
1779 1779
1780 LInstruction* LChunkBuilder::DoLoadGlobalCell(HLoadGlobalCell* instr) { 1780 LInstruction* LChunkBuilder::DoLoadGlobalCell(HLoadGlobalCell* instr) {
1781 LLoadGlobalCell* result = new LLoadGlobalCell; 1781 LLoadGlobalCell* result = new LLoadGlobalCell;
1782 return instr->check_hole_value() 1782 return instr->RequiresHoleCheck()
1783 ? AssignEnvironment(DefineAsRegister(result)) 1783 ? AssignEnvironment(DefineAsRegister(result))
1784 : DefineAsRegister(result); 1784 : DefineAsRegister(result);
1785 } 1785 }
1786 1786
1787 1787
1788 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) { 1788 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) {
1789 LOperand* context = UseFixed(instr->context(), esi); 1789 LOperand* context = UseFixed(instr->context(), esi);
1790 LOperand* global_object = UseFixed(instr->global_object(), eax); 1790 LOperand* global_object = UseFixed(instr->global_object(), eax);
1791 LLoadGlobalGeneric* result = new LLoadGlobalGeneric(context, global_object); 1791 LLoadGlobalGeneric* result = new LLoadGlobalGeneric(context, global_object);
1792 return MarkAsCall(DefineFixed(result, eax), instr); 1792 return MarkAsCall(DefineFixed(result, eax), instr);
1793 } 1793 }
1794 1794
1795 1795
1796 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) { 1796 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) {
1797 LStoreGlobalCell* result = 1797 LStoreGlobalCell* result =
1798 new LStoreGlobalCell(UseTempRegister(instr->value()), 1798 new LStoreGlobalCell(UseTempRegister(instr->value()),
1799 TempRegister(), 1799 TempRegister(),
1800 TempRegister()); 1800 TempRegister());
1801 return instr->check_hole_value() ? AssignEnvironment(result) : result; 1801 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result;
1802 } 1802 }
1803 1803
1804 1804
1805 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) { 1805 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) {
1806 LOperand* context = UseFixed(instr->context(), esi); 1806 LOperand* context = UseFixed(instr->context(), esi);
1807 LOperand* global_object = UseFixed(instr->global_object(), edx); 1807 LOperand* global_object = UseFixed(instr->global_object(), edx);
1808 LOperand* value = UseFixed(instr->value(), eax); 1808 LOperand* value = UseFixed(instr->value(), eax);
1809 LStoreGlobalGeneric* result = 1809 LStoreGlobalGeneric* result =
1810 new LStoreGlobalGeneric(context, global_object, value); 1810 new LStoreGlobalGeneric(context, global_object, value);
1811 return MarkAsCall(result, instr); 1811 return MarkAsCall(result, instr);
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
2272 LOperand* key = UseOrConstantAtStart(instr->key()); 2272 LOperand* key = UseOrConstantAtStart(instr->key());
2273 LOperand* object = UseOrConstantAtStart(instr->object()); 2273 LOperand* object = UseOrConstantAtStart(instr->object());
2274 LIn* result = new LIn(context, key, object); 2274 LIn* result = new LIn(context, key, object);
2275 return MarkAsCall(DefineFixed(result, eax), instr); 2275 return MarkAsCall(DefineFixed(result, eax), instr);
2276 } 2276 }
2277 2277
2278 2278
2279 } } // namespace v8::internal 2279 } } // namespace v8::internal
2280 2280
2281 #endif // V8_TARGET_ARCH_IA32 2281 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698