Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 8054008: Improve our simple elimination of hole checks. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1721 matching lines...) Expand 10 before | Expand all | Expand 10 after
1732 return DefineAsRegister(new LConstantT); 1732 return DefineAsRegister(new LConstantT);
1733 } else { 1733 } else {
1734 UNREACHABLE(); 1734 UNREACHABLE();
1735 return NULL; 1735 return NULL;
1736 } 1736 }
1737 } 1737 }
1738 1738
1739 1739
1740 LInstruction* LChunkBuilder::DoLoadGlobalCell(HLoadGlobalCell* instr) { 1740 LInstruction* LChunkBuilder::DoLoadGlobalCell(HLoadGlobalCell* instr) {
1741 LLoadGlobalCell* result = new LLoadGlobalCell; 1741 LLoadGlobalCell* result = new LLoadGlobalCell;
1742 return instr->check_hole_value() 1742 return instr->RequiresHoleCheck()
1743 ? AssignEnvironment(DefineAsRegister(result)) 1743 ? AssignEnvironment(DefineAsRegister(result))
1744 : DefineAsRegister(result); 1744 : DefineAsRegister(result);
1745 } 1745 }
1746 1746
1747 1747
1748 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) { 1748 LInstruction* LChunkBuilder::DoLoadGlobalGeneric(HLoadGlobalGeneric* instr) {
1749 LOperand* global_object = UseFixed(instr->global_object(), r0); 1749 LOperand* global_object = UseFixed(instr->global_object(), r0);
1750 LLoadGlobalGeneric* result = new LLoadGlobalGeneric(global_object); 1750 LLoadGlobalGeneric* result = new LLoadGlobalGeneric(global_object);
1751 return MarkAsCall(DefineFixed(result, r0), instr); 1751 return MarkAsCall(DefineFixed(result, r0), instr);
1752 } 1752 }
1753 1753
1754 1754
1755 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) { 1755 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) {
1756 LOperand* temp = TempRegister(); 1756 LOperand* temp = TempRegister();
1757 LOperand* value = UseTempRegister(instr->value()); 1757 LOperand* value = UseTempRegister(instr->value());
1758 LInstruction* result = new LStoreGlobalCell(value, temp); 1758 LInstruction* result = new LStoreGlobalCell(value, temp);
1759 if (instr->check_hole_value()) result = AssignEnvironment(result); 1759 if (instr->RequiresHoleCheck()) result = AssignEnvironment(result);
1760 return result; 1760 return result;
1761 } 1761 }
1762 1762
1763 1763
1764 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) { 1764 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) {
1765 LOperand* global_object = UseFixed(instr->global_object(), r1); 1765 LOperand* global_object = UseFixed(instr->global_object(), r1);
1766 LOperand* value = UseFixed(instr->value(), r0); 1766 LOperand* value = UseFixed(instr->value(), r0);
1767 LStoreGlobalGeneric* result = 1767 LStoreGlobalGeneric* result =
1768 new LStoreGlobalGeneric(global_object, value); 1768 new LStoreGlobalGeneric(global_object, value);
1769 return MarkAsCall(result, instr); 1769 return MarkAsCall(result, instr);
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
2184 2184
2185 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2185 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2186 LOperand* key = UseRegisterAtStart(instr->key()); 2186 LOperand* key = UseRegisterAtStart(instr->key());
2187 LOperand* object = UseRegisterAtStart(instr->object()); 2187 LOperand* object = UseRegisterAtStart(instr->object());
2188 LIn* result = new LIn(key, object); 2188 LIn* result = new LIn(key, object);
2189 return MarkAsCall(DefineFixed(result, r0), instr); 2189 return MarkAsCall(DefineFixed(result, r0), instr);
2190 } 2190 }
2191 2191
2192 2192
2193 } } // namespace v8::internal 2193 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698