Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: benchmarks/run.html

Issue 8053: Improve error reporting in benchmarks. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « benchmarks/base.js ('k') | benchmarks/run.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: benchmarks/run.html
===================================================================
--- benchmarks/run.html (revision 549)
+++ benchmarks/run.html (working copy)
@@ -63,6 +63,8 @@
<script type="text/javascript">
var completed = 0;
var benchmarks = BenchmarkSuite.CountBenchmarks();
+var success = true;
+
function ShowProgress(name) {
var status = document.getElementById("status");
var percentage = ((++completed) / benchmarks) * 100;
@@ -77,14 +79,23 @@
}
+function AddError(name, error) {
+ AddResult(name, '<b>error</b>');
+ success = false;
+}
+
+
function AddScore(score) {
var status = document.getElementById("status");
- status.innerHTML = "Score: " + score;
+ if (success) {
+ status.innerHTML = "Score: " + score;
+ }
}
function Run() {
BenchmarkSuite.RunSuites({ NotifyStep: ShowProgress,
+ NotifyError: AddError,
NotifyResult: AddResult,
NotifyScore: AddScore });
}
« no previous file with comments | « benchmarks/base.js ('k') | benchmarks/run.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698