Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 8052031: Add /bigobj parameter to cctest to make MSVS happy. (Closed)

Created:
9 years, 2 months ago by Jakob Kummerow
Modified:
9 years, 2 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Add /bigobj parameter to cctest to make MSVS happy. TEST=MSVS 2008 compiles cctest without warnings/errors. Committed: http://code.google.com/p/v8/source/detail?r=9458

Patch Set 1 #

Patch Set 2 : added output directory change from issue 8055031 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL. No idea why it's started complaining now...
9 years, 2 months ago (2011-09-28 09:03:32 UTC) #1
Rico
LGTM
9 years, 2 months ago (2011-09-28 09:07:15 UTC) #2
Rico
9 years, 2 months ago (2011-09-28 09:09:40 UTC) #3
Still lgtm

Powered by Google App Engine
This is Rietveld 408576698