Issue 8052029: Pregenerate a RecordWrite stub that we need in the new CallFunctionStub

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8052029: Pregenerate a RecordWrite stub that we need in the new CallFunctionStub (Closed)

Created:
9 years, 2 months ago by Erik Corry

Modified:
9 years, 2 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make sure we don't flush the pregenerated stubs, since they need to be always present, so that we can call them from other stubs without trying to generate stubs while we are generating stubs. Committed: http://code.google.com/p/v8/source/detail?r=9459

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -22 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 2	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 2	4 chunks	+5 lines, -4 lines	0 comments	Download
M	src/isolate.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/stub-cache.cc	View	1 2	2 chunks	+20 lines, -7 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Rico

9 years, 2 months ago (2011-09-28 10:28:04 UTC) #4

LGTM
Maybe we could add a few asserts from where we call these stubs to actually make
sure that the pregenerated flag is set and keeps?

Expand Messages | Collapse Messages