chrome/browser/resources/ntp4/most_visited_page.js - Issue 8052028: NTP: Clean up of MetricsHandler class and namespacing chrome.send messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/most_visited_page.js

Issue 8052028: NTP: Clean up of MetricsHandler class and namespacing chrome.send messages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tried to remove dependencies of metricshandler, most still necessary in NewTabUI Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/ntp4/logging.js ('k') | chrome/browser/ui/webui/ntp/metrics_handler.h » ('j') | chrome/browser/ui/webui/ntp/metrics_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/ntp4/most_visited_page.js

diff --git a/chrome/browser/resources/ntp4/most_visited_page.js b/chrome/browser/resources/ntp4/most_visited_page.js

index da86ee6966a0d70d876760af277be30fa53a67b6..4242c10306050d4900808e0a6152bf033a529468 100644

--- a/chrome/browser/resources/ntp4/most_visited_page.js

+++ b/chrome/browser/resources/ntp4/most_visited_page.js

@@ -141,7 +141,8 @@ cr.define('ntp4', function() {

[encodeURIComponent(this.href),

ntp4.APP_LAUNCH.NTP_MOST_VISITED]);

// Records the index of this tile.

- chrome.send('recordInHistogram', ['NTP_MostVisited', this.index, 8]);

+ chrome.send('metricsHandler:recordInHistogram',

+ ['NTP_MostVisited', this.index, 8]);

}

« no previous file with comments | « chrome/browser/resources/ntp4/logging.js ('k') | chrome/browser/ui/webui/ntp/metrics_handler.h » ('j') | chrome/browser/ui/webui/ntp/metrics_handler.h » ('J')