chrome/browser/resources/ntp/most_visited.js - Issue 8052028: NTP: Clean up of MetricsHandler class and namespacing chrome.send messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp/most_visited.js

Issue 8052028: NTP: Clean up of MetricsHandler class and namespacing chrome.send messages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tried to remove dependencies of metricshandler, most still necessary in NewTabUI Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/ntp/most_visited.js

diff --git a/chrome/browser/resources/ntp/most_visited.js b/chrome/browser/resources/ntp/most_visited.js

index 1b2202798001ba74120c864b1ef0623dae2e2c2f..a6a91eab3f595d9c67567b8005a810a7d731fe46 100644

--- a/chrome/browser/resources/ntp/most_visited.js

+++ b/chrome/browser/resources/ntp/most_visited.js

@@ -103,7 +103,7 @@ var MostVisited = (function() {

this.data[destinationIndex] = sourceData;

this.data[sourceIndex] = destinationData;

- chrome.send('recordAction', ['MostVisitedReordered']);

+ chrome.send('metricsHandler:recordAction', ['MostVisitedReordered']);

updateSettingsLink: function(hasBlacklistedUrls) {

@@ -540,7 +540,7 @@ var MostVisited = (function() {

var hoverDuration = (new Date()).getTime() - this.hoverStartTime_;

if (hoverDuration > 500)

hoverDuration = 500;

- chrome.send('recordInHistogram',

+ chrome.send('metricsHandler:recordInHistogram',

[clicked ? 'NewTabPage.HoverTimeClicked'

: 'NewTabPage.HoverTimeNotClicked',

hoverDuration,

@@ -692,7 +692,7 @@ var MostVisited = (function() {

item);

this.RecordHoverTime_(true);

if (index != -1)

- chrome.send('recordInHistogram',

+ chrome.send('metricsHandler:recordInHistogram',

['NewTabPage.MostVisited', index, 8]);

}

« no previous file with comments | « chrome/browser/resources/new_tab.html ('k') | chrome/browser/resources/ntp4/logging.js » ('j') | chrome/browser/ui/webui/ntp/metrics_handler.h » ('J')