Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 8052024: Autofill: Ignore gift cards when filling credit card info (Closed)

Created:
9 years, 2 months ago by Ilya Sherman
Modified:
9 years, 2 months ago
CC:
chromium-reviews, GeorgeY, Paweł Hajdan Jr., Ilya Sherman, dhollowa
Visibility:
Public.

Description

Autofill: Ignore gift cards when filling credit card info BUG=98338 TEST=browser_tests --gtest_filter=*DataDrivenHeuristics* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -3 lines) Patch
M chrome/browser/autofill/autofill_regex_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_regex_constants.cc.utf8 View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/autofill/credit_card_field.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/autofill/form_structure_browsertest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/input/17_crbug_98338.html View 1 chunk +301 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/output/17_crbug_98338.out View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ilya Sherman
9 years, 2 months ago (2011-09-28 00:05:45 UTC) #1
dhollowa
lgtm
9 years, 2 months ago (2011-09-28 01:11:46 UTC) #2
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8052024/1
9 years, 2 months ago (2011-09-28 01:11:56 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-09-28 03:37:45 UTC) #4
Change committed as 103085

Powered by Google App Engine
This is Rietveld 408576698