chrome/renderer/print_web_view_helper_linux.cc - Issue 8052020: Revert 103021 - PrintPreview: Printing preview of a PDF on Mac with Skia only previews the last p...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/print_web_view_helper_linux.cc

Issue 8052020: Revert 103021 - PrintPreview: Printing preview of a PDF on Mac with Skia only previews the last p... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/print_web_view_helper_linux.cc

===================================================================

--- chrome/renderer/print_web_view_helper_linux.cc (revision 103025)

+++ chrome/renderer/print_web_view_helper_linux.cc (working copy)

@@ -14,7 +14,6 @@

#include "printing/metafile_impl.h"

#include "printing/metafile_skia_wrapper.h"

#include "printing/page_size_margins.h"

-#include "skia/ext/platform_device.h"

#include "skia/ext/vector_canvas.h"

#include "third_party/skia/include/core/SkRefCnt.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"

@@ -209,8 +208,9 @@

// can't be a stack object.

SkRefPtr<skia::VectorCanvas> canvas = new skia::VectorCanvas(device);

canvas->unref(); // SkRefPtr and new both took a reference.

- printing::MetafileSkiaWrapper::SetMetafileOnCanvas(*canvas, metafile);

- skia::SetIsDraftMode(*canvas, is_print_ready_metafile_sent_);

+ printing::MetafileSkiaWrapper::SetMetafileOnCanvas(canvas.get(), metafile);

+ printing::MetafileSkiaWrapper::SetDraftMode(canvas.get(),

+ is_print_ready_metafile_sent_);

frame->printPage(params.page_number, canvas.get());

if (params.params.display_header_footer) {

« no previous file with comments | « chrome/renderer/print_web_view_helper.h ('k') | chrome/renderer/print_web_view_helper_mac.mm » ('j') | no next file with comments »