Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/ui/views/constrained_window_views.cc

Issue 8052019: Create constrained windows in a hidden state. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and address comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/constrained_window_views_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/constrained_window_views.cc
diff --git a/chrome/browser/ui/views/constrained_window_views.cc b/chrome/browser/ui/views/constrained_window_views.cc
index b9f5af59a7e2509a1529c2e7366daf09b76c79d5..2af44a82415961d5a17ee2a05feffe1fe274bd36 100644
--- a/chrome/browser/ui/views/constrained_window_views.cc
+++ b/chrome/browser/ui/views/constrained_window_views.cc
@@ -620,14 +620,11 @@ ConstrainedWindowViews::~ConstrainedWindowViews() {
// ConstrainedWindowViews, ConstrainedWindow implementation:
void ConstrainedWindowViews::ShowConstrainedWindow() {
- // We marked the view as hidden during construction. Mark it as
- // visible now so FocusManager will let us receive focus.
- non_client_view()->SetVisible(true);
ConstrainedWindowTabHelper* helper =
wrapper_->constrained_window_tab_helper();
if (helper && helper->delegate())
helper->delegate()->WillShowConstrainedWindow(wrapper_);
- Activate();
+ Show();
FocusConstrainedWindow();
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/constrained_window_views_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698