Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2880)

Unified Diff: chrome/browser/ui/views/constrained_window_views.cc

Issue 8052019: Create constrained windows in a hidden state. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/constrained_window_views.cc
diff --git a/chrome/browser/ui/views/constrained_window_views.cc b/chrome/browser/ui/views/constrained_window_views.cc
index d48427cd9172c6474c186ad7b5fd8de98674e1ab..2d48f44eae2955a4ae419cb0ebbc0434b2f79d0b 100644
--- a/chrome/browser/ui/views/constrained_window_views.cc
+++ b/chrome/browser/ui/views/constrained_window_views.cc
@@ -615,14 +615,11 @@ ConstrainedWindowViews::~ConstrainedWindowViews() {
// ConstrainedWindowViews, ConstrainedWindow implementation:
void ConstrainedWindowViews::ShowConstrainedWindow() {
- // We marked the view as hidden during construction. Mark it as
- // visible now so FocusManager will let us receive focus.
- non_client_view()->SetVisible(true);
ConstrainedWindowTabHelper* helper =
wrapper_->constrained_window_tab_helper();
if (helper && helper->delegate())
helper->delegate()->WillShowConstrainedWindow(wrapper_);
- Activate();
+ Show();
FocusConstrainedWindow();
}

Powered by Google App Engine
This is Rietveld 408576698