Create constrained windows in a hidden state.

chrome/browser/ui/views/constrained_window_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/constrained_window_views.h"
 
 #include <algorithm>
 
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 586 matching lines @@
     // desktop. This is necessary for key events to work under views desktop
     // because key events need to be sent to toplevel window
     // which has an inputmethod object that knows where to forward
     // event.
   } else {
     params.child = true;
     params.parent = wrapper->tab_contents()->GetNativeView();
   }
 
   Init(params);
-
+  // Views default to visible.  Since we are creating a window that is not
+  // visible, mark our View as hidden.  This lets us manage accelerator
+  // registration and focus in a manner consistent with visibility.

[Ben Goodger (Google), 2011/10/26 18:04:58]

Seems like the NCV should just defer registration until its widget is visible,
or that those accelerators should not be reachable for an invisible widget.

[asanka, 2011/10/26 18:46:25]

Yeah. I think that would be better. Views::RegisterPendingAccelerators() already
defers accelerator registration based on IsVisibleInRootView().  Should it
consider the visibility of the widget as well?

In the meantime I'll see if I can get NCV to defer registration.

+  non_client_view()->SetVisible(false);
   wrapper_->constrained_window_tab_helper()->AddConstrainedDialog(this);
 }
 
 ConstrainedWindowViews::~ConstrainedWindowViews() {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // ConstrainedWindowViews, ConstrainedWindow implementation:
 
 void ConstrainedWindowViews::ShowConstrainedWindow() {
@@ skipping 39 matching lines @@
 }
 
 void ConstrainedWindowViews::OnNativeConstrainedWindowMouseActivate() {
   Activate();
 }
 
 views::internal::NativeWidgetDelegate*
     ConstrainedWindowViews::AsNativeWidgetDelegate() {
   return this;
 }