chrome/browser/content_settings/host_content_settings_map_unittest.cc - Issue 8051030: Changing third-party cookie blocking: strict by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/host_content_settings_map_unittest.cc

Issue 8051030: Changing third-party cookie blocking: strict by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/content_settings/host_content_settings_map.cc ('K') | « chrome/browser/content_settings/host_content_settings_map.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/host_content_settings_map_unittest.cc

diff --git a/chrome/browser/content_settings/host_content_settings_map_unittest.cc b/chrome/browser/content_settings/host_content_settings_map_unittest.cc

index caa66edfcd8a1cb9afc3d4be5faafb12a44031a8..cdc5ba6f7879ebca31224b61d85cb8ace6101894 100644

--- a/chrome/browser/content_settings/host_content_settings_map_unittest.cc

+++ b/chrome/browser/content_settings/host_content_settings_map_unittest.cc

@@ -1109,16 +1109,6 @@ TEST_F(HostContentSettingsMapTest, CookiesBlockThirdParty) {

HostContentSettingsMap* host_content_settings_map =

profile.GetHostContentSettingsMap();

host_content_settings_map->SetBlockThirdPartyCookies(true);

- EXPECT_EQ(CONTENT_SETTING_ALLOW,

- host_content_settings_map->GetCookieContentSetting(

- kBlockedSite, kFirstPartySite, false));

- EXPECT_EQ(CONTENT_SETTING_BLOCK,

- host_content_settings_map->GetCookieContentSetting(

- kBlockedSite, kFirstPartySite, true));

- CommandLine* cmd = CommandLine::ForCurrentProcess();

- AutoReset<CommandLine> auto_reset(cmd, *cmd);

- cmd->AppendSwitch(switches::kBlockReadingThirdPartyCookies);

EXPECT_EQ(CONTENT_SETTING_BLOCK,

host_content_settings_map->GetCookieContentSetting(

@@ -1203,22 +1193,6 @@ TEST_F(HostContentSettingsMapTest, CookiesThirdPartyBlockedExplicitAllow) {

EXPECT_EQ(CONTENT_SETTING_ALLOW,

host_content_settings_map->GetCookieContentSetting(

kAllowedSite, kExtensionURL, true));

- CommandLine* cmd = CommandLine::ForCurrentProcess();

- AutoReset<CommandLine> auto_reset(cmd, *cmd);

- cmd->AppendSwitch(switches::kBlockReadingThirdPartyCookies);

- EXPECT_EQ(CONTENT_SETTING_ALLOW,

- host_content_settings_map->GetCookieContentSetting(

- kAllowedSite, kFirstPartySite, false));

- // Extensions should always be allowed to use cookies.

- EXPECT_EQ(CONTENT_SETTING_ALLOW,

- host_content_settings_map->GetCookieContentSetting(

- kAllowedSite, kExtensionURL, false));

- EXPECT_EQ(CONTENT_SETTING_ALLOW,

- host_content_settings_map->GetCookieContentSetting(

- kAllowedSite, kExtensionURL, true));

}

TEST_F(HostContentSettingsMapTest, CookiesBlockEverything) {