Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: src/mark-compact.cc

Issue 8051014: Fix slot buffers of abandoned evacuation candidates. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mark-compact.cc
diff --git a/src/mark-compact.cc b/src/mark-compact.cc
index 956d0c953a0dbddcb3adcae3eadc80037cf10297..0196349511c983330c96942e160fd8f3bb6c6556 100644
--- a/src/mark-compact.cc
+++ b/src/mark-compact.cc
@@ -2690,8 +2690,10 @@ void MarkCompactCollector::EvacuatePages() {
// Without room for expansion evacuation is not guaranteed to succeed.
// Pessimistically abandon unevacuated pages.
for (int j = i; j < npages; j++) {
- evacuation_candidates_[j]->ClearEvacuationCandidate();
- evacuation_candidates_[j]->SetFlag(Page::RESCAN_ON_EVACUATION);
+ p = evacuation_candidates_[j];
Vyacheslav Egorov (Chromium) 2011/09/27 13:24:56 it's a bit shady to reuse p from the outer scope h
Michael Starzinger 2011/09/27 13:34:43 Done.
+ slots_buffer_allocator_.DeallocateChain(p->slots_buffer_address());
+ p->ClearEvacuationCandidate();
+ p->SetFlag(Page::RESCAN_ON_EVACUATION);
}
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698