Issue 8051014: Fix slot buffers of abandoned evacuation candidates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8051014: Fix slot buffers of abandoned evacuation candidates. (Closed)

Created:
9 years, 2 months ago by Michael Starzinger

Modified:
9 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix slot buffers of abandoned evacuation candidates. R=vegorov@chromium.org BUG=v8:1734 TEST=cctest/test-mark-compact/NoPromotion Committed: http://code.google.com/p/v8/source/detail?r=9454

Patch Set 2 : Addressed comment by Vyacheslav Egorov. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/mark-compact.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM! http://codereview.chromium.org/8051014/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/8051014/diff/1/src/mark-compact.cc#newcode2693 src/mark-compact.cc:2693: p = evacuation_candidates_[j]; it's a bit shady to ...

9 years, 2 months ago (2011-09-27 13:24:56 UTC) #2

Michael Starzinger

9 years, 2 months ago (2011-09-27 13:34:43 UTC) #3

Added new patch set.

http://codereview.chromium.org/8051014/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/8051014/diff/1/src/mark-compact.cc#newcode2693
src/mark-compact.cc:2693: p = evacuation_candidates_[j];
On 2011/09/27 13:24:56, Vyacheslav Egorov wrote:
> it's a bit shady to reuse p from the outer scope here, might lead to confusion
> in future.
> 
> consider having a separate variable.

Done.

Expand Messages | Collapse Messages

Issue 8051014: Fix slot buffers of abandoned evacuation candidates. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment by Vyacheslav Egorov. #

Messages