Issue 805005: Revert changes 4088 and 4087 to fix build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 805005: Revert changes 4088 and 4087 to fix build. (Closed)

Created:
10 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Revert changes 4088 and 4087 to fix build. Committed: http://code.google.com/p/v8/source/detail?r=4089

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -703 lines)			Patch
M	src/arm/virtual-frame-arm.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/ast.h	View	11 chunks	+3 lines, -32 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+1 line, -15 lines	0 comments	Download
M	src/compiler.cc	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	src/data-flow.h	View	2 chunks	+1 line, -35 lines	0 comments	Download
M	src/data-flow.cc	View	2 chunks	+0 lines, -440 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	6 chunks	+78 lines, -131 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/ia32/virtual-frame-ia32.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ia32/virtual-frame-ia32.cc	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	src/scopes.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/virtual-frame-inl.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/x64/virtual-frame-x64.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

William Hesse

tbr=fschneider@chromium.org. Revert 4088 and 4087 that cause a sputnik failure.

10 years, 9 months ago (2010-03-10 20:40:18 UTC) #1

fschneider

10 years, 9 months ago (2010-03-11 09:38:26 UTC) #2

LGTM.

Sorry, I thought I fixed the builder error already.