Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 805004: Do not waste space for the fast-case elements backing storage for ... (Closed)

Created:
10 years, 9 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Do not waste space for the fast-case elements backing storage for object-literals with few elements but large element indices. We can decide at parse time whether the created object literal should have fast-case of slow-case elements. Remove unused runtime function. Committed: http://code.google.com/p/v8/source/detail?r=4100

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -56 lines) Patch
M src/arm/codegen-arm.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M src/ast.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/ia32/codegen-ia32.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/parser.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/parser.cc View 6 chunks +36 lines, -2 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/runtime.cc View 6 chunks +22 lines, -27 lines 1 comment Download
M src/x64/codegen-x64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
10 years, 9 months ago (2010-03-10 18:32:14 UTC) #1
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-11 08:28:59 UTC) #2
LGTM

http://codereview.chromium.org/805004/diff/1/5
File src/runtime.cc (right):

http://codereview.chromium.org/805004/diff/1/5#newcode392
src/runtime.cc:392: CONVERT_SMI_CHECKED(fast_elements, args[3]);
Why is this argument not a Boolean object? To save relocinfo space?

Powered by Google App Engine
This is Rietveld 408576698