Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 8050017: Extract filenames from diffs better. (Closed)

Created:
9 years, 2 months ago by Alexei Svitkine (slow)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Extract filenames from diffs better. This is a followup to: http://codereview.chromium.org/8059009/ Only add the file once instead of twice (since the diff has --- and +++ lines for each file). Strip whitespace at the end (git diffs don't include a \t so split('\t') isn't enough). Remove leading 'a/' from the path, since git diffs have these. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102934

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M trychange.py View 1 chunk +5 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Alexei Svitkine (slow)
9 years, 2 months ago (2011-09-27 14:55:46 UTC) #1
M-A Ruel
lgtm http://codereview.chromium.org/8050017/diff/1/trychange.py File trychange.py (right): http://codereview.chromium.org/8050017/diff/1/trychange.py#newcode481 trychange.py:481: if diff[i].startswith('--- '): Maybe time to? import patch ...
9 years, 2 months ago (2011-09-27 15:00:45 UTC) #2
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8050017/1
9 years, 2 months ago (2011-09-27 15:05:11 UTC) #3
Alexei Svitkine (slow)
http://codereview.chromium.org/8050017/diff/1/trychange.py File trychange.py (right): http://codereview.chromium.org/8050017/diff/1/trychange.py#newcode481 trychange.py:481: if diff[i].startswith('--- '): On 2011/09/27 15:00:45, Marc-Antoine Ruel wrote: ...
9 years, 2 months ago (2011-09-27 15:05:13 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-09-27 15:11:02 UTC) #5
Change committed as 102934

Powered by Google App Engine
This is Rietveld 408576698