Support for precise stepping in functions compiled before debugging was started (step 2)

src/compiler.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 102 matching lines @@
     pre_parse_data_ = pre_parse_data;
   }
   void SetCallingContext(Handle<Context> context) {
     ASSERT(is_eval());
     calling_context_ = context;
   }
   void SetOsrAstId(int osr_ast_id) {
     ASSERT(IsOptimizing());
     osr_ast_id_ = osr_ast_id;
   }
+  void MarkCompilingForDebugging(Handle<Code> current_code) {
+    ASSERT(mode_ != OPTIMIZE);
+    ASSERT(current_code->kind() == Code::FUNCTION);
+    compiling_for_debugging_ = true;
+    if (current_code->is_compiled_optimizable()) {
+      EnableDeoptimizationSupport();
+    } else {
+      mode_ = CompilationInfo::NONOPT;
+    }
+  }
+  bool CompilingForDebugging() { return compiling_for_debugging_; }
 
   bool has_global_object() const {
     return !closure().is_null() && (closure()->context()->global() != NULL);
   }
 
   GlobalObject* global_object() const {
     return has_global_object() ? closure()->context()->global() : NULL;
   }
 
   // Accessors for the different compilation modes.
@@ skipping 94 matching lines @@
 
   // The context of the caller is needed for eval code, and will be a null
   // handle otherwise.
   Handle<Context> calling_context_;
 
   // Compilation mode flag and whether deoptimization is allowed.
   Mode mode_;
   bool supports_deoptimization_;
   int osr_ast_id_;
 
+  // If compiling for debugging produce just full code matching the
+  // initial mode setting.
+  bool compiling_for_debugging_;

[Kevin Millikin (Chromium), 2011/09/29 10:47:35]

There's a bit field "flags_" in this class.  I think this bit (as well as
supports_deoptimization_) should be packed in there.

Conveniently, the flags all default to false.

[Søren Thygesen Gjesse, 2011/09/30 08:33:22]

Good point - changed.

+
   DISALLOW_COPY_AND_ASSIGN(CompilationInfo);
 };
 
 
 // The V8 compiler
 //
 // General strategy: Source code is translated into an anonymous function w/o
 // parameters which then can be executed. If the source code contains other
 // functions, they will be compiled and allocated as part of the compilation
 // of the source code.
@@ skipping 51 matching lines @@
 
   static void RecordFunctionCompilation(Logger::LogEventsAndTags tag,
                                         CompilationInfo* info,
                                         Handle<SharedFunctionInfo> shared);
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_COMPILER_H_