Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8050008: gcc 4.6 warnings cleanup (Closed)

Created:
9 years, 2 months ago by ph34r
Modified:
9 years, 2 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, brettw-cc_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), kinuko+watch, scherkus (not reviewing)
Visibility:
Public.

Description

gcc 4.6 warnings cleanup BUG=87490 TEST=compile with gcc 4.6 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103513

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -20 lines) Patch
M base/tools_sanity_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/history_browsertest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/video/ffmpeg_video_decode_engine_unittest.cc View 2 chunks +1 line, -6 lines 0 comments Download
M ui/gfx/surface/accelerated_surface_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_usage_cache.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ph34r
darin - base & webkit sky - ui & history acolwell - media
9 years, 2 months ago (2011-09-27 10:23:31 UTC) #1
acolwell GONE FROM CHROMIUM
media changes LGTM
9 years, 2 months ago (2011-09-27 16:00:47 UTC) #2
sky
chrome and ui LGTM
9 years, 2 months ago (2011-09-27 16:41:44 UTC) #3
ph34r
darin, ping :)
9 years, 2 months ago (2011-09-29 08:44:52 UTC) #4
ph34r
I've added willchan (base) and michaeln (webkit) to the list of reviewers. Please review this ...
9 years, 2 months ago (2011-09-30 10:30:30 UTC) #5
darin (slow to review)
LGTM
9 years, 2 months ago (2011-09-30 17:22:26 UTC) #6
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/pph34r@gmail.com/8050008/1
9 years, 2 months ago (2011-09-30 17:39:27 UTC) #7
commit-bot: I haz the power
9 years, 2 months ago (2011-09-30 18:52:05 UTC) #8 
Change committed as 103513

Powered by Google App Engine
This is Rietveld 408576698