Changed the message reporting for try { ... } finally { ... } statements to...

Changed the message reporting for try { ... } finally { ... } statements to
report the exception when they happen in the try block and not as previously
when re-thrown after execution of the finally block. There is no longer any
message generated by re-throw.

Added test cases for various combinations of try/catch/finally with throw in
different places.

Added a regression directory to the messages tests which is processed by the
test runner.

Added regression tests for the specific bugs fixed.

Runs all the test suites.

BUG=73
BUG=75
Committed: http://code.google.com/p/v8/source/detail?r=565

[Søren Thygesen Gjesse, 2008-10-22 08:07:05]

Both mozilla and escft tests run.

There is one thing I don't like, and that is the line

  thread_local_.external_caught_exception_ = false;

in Top::DoThrow.

The reason for it being there is that

  try { } catch { } finally { }

is rewritten in the AST as

  try { try { } catch { } } finally { }

When there is a throw both in the catch and in the finally and a C++ TryCatch
outside then the exception from the catch will be registered with the C++
TryCatch, but will have to be overwritten by the exception form the finally.

Thinking of that it probably will be an issue with the MessageHandler if there
is no C++ TryCatch as it will be called with both the throw in the catch and the
throw in the finally. There is no message test using the MessageHandler.

[Christian Plesner Hansen, 2008-10-22 09:18:59]

As discussed, we should probably just disable the assertion that crashes when
external_caught_exception_ is already set, since it doesn't actually hold that
you can only throw an externally caught exception once.

[Søren Thygesen Gjesse, 2008-10-23 07:29:40]

New change list uploaded which no longer resets the externally caught flag to
circumvent an ASSERTION it TryCall. Changed the use of TryCall in
MakeMessageObject to use its own catcher and explained why.

[Christian Plesner Hansen, 2008-10-23 07:53:43]

Lgtm

http://codereview.chromium.org/8050/diff/21/237
File src/top.cc (right):

http://codereview.chromium.org/8050/diff/21/237#newcode792
Line 792: if (is_caught_externally) {
Maybe this should be skipped on is_rethrow too?

[Søren Thygesen Gjesse, 2008-10-23 08:32:45]

Refactored the flag is_rethrow out of DoThrow as very little was done on
rethrow. Rethrow now handles this directly.

http://codereview.chromium.org/8050/diff/21/237
File src/top.cc (right):

http://codereview.chromium.org/8050/diff/21/237#newcode792
Line 792: if (is_caught_externally) {
On 2008/10/23 07:53:43, Christian Plesner Hansen wrote:
> Maybe this should be skipped on is_rethrow too?

The is_rethrow flag to DoThrow have been removed.

[Christian Plesner Hansen, 2008-10-23 08:35:03]

Sticks the value!