Issue 8049002: Don't show hidden devices in UI (exept from imageburner).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8049002: Don't show hidden devices in UI (exept from imageburner). (Closed)

Created:
9 years, 2 months ago by tbarzic

Modified:
9 years, 2 months ago

Reviewers:
zel

CC:
chromium-reviews, stevenjb, nkostylev+watch_chromium.org, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Don't show hidden devices in UI (exept from imageburner). At the moment CrosDisks does not send signals for devices that should not be automounted. Unfortunately, this breaks imageburner, so we are changing CrosDisks to start sending events for those devices, but marks them hidden. This CL should ensure that those devices get processed only in context of imageburner. libcros change: http://gerrit.chromium.org/gerrit/#change,8216 TEST=Verified that all attached removable devices show up on chrome://imageburner Checked that hidden devices are not shown in file browser, or attempted to be mounted. BUG=chromium-os:20476 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103965

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -11 lines)			Patch
M	chrome/browser/chromeos/cros/mock_mount_library.cc	View	1 2 3 4	3 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/mount_library.h	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/mount_library.cc	View	1 2	6 chunks	+16 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/extensions/file_browser_event_router.cc	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_file_browser_private_api.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_file_browser_private_apitest.cc	View	1 2 3	3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 8049002: Don't show hidden devices in UI (exept from imageburner). (Closed)

Description

Patch Set 1 #

Patch Set 2 : sending diskAdded events should not be forbidden for hidden devices #

Patch Set 3 : none #

Patch Set 4 : 'amend file_browser_private_api test' #

Patch Set 5 : 'mock library update' #

Messages