Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 8046028: Fix issue with print preview on Chrome OS just displaying an error message. (Closed)

Created:
9 years, 2 months ago by Albert Bodenhamer
Modified:
9 years, 2 months ago
Reviewers:
arthurhsu, dpapad
CC:
chromium-reviews
Visibility:
Public.

Description

Fix issue with print preview on Chrome OS just displaying an error message. Default settings were not getting set up after a recent change to settings handling. BUG=http://code.google.com/p/chromium-os/issues/detail?id=20787 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103005

Patch Set 1 #

Patch Set 2 : Removed extra {} #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M printing/printing_context_cairo.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Albert Bodenhamer
9 years, 2 months ago (2011-09-27 00:15:51 UTC) #1
arthurhsu
lgtm
9 years, 2 months ago (2011-09-27 00:19:45 UTC) #2
dpapad
9 years, 2 months ago (2011-09-27 00:58:36 UTC) #3
LGTM. Tested an it does solve the problem.

Powered by Google App Engine
This is Rietveld 408576698