Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1348)

Issue 8046012: Make media/ PIC-clean on 32-bit Linux. (Closed)

Created:
9 years, 2 months ago by agl
Modified:
9 years, 2 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Make media/ PIC-clean on 32-bit Linux. This change sets the asm defines so that code in media/ doesn't require text relocations on 32-bit Linux. BUG=87704 TEST=Try running Chrome on Fedora Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102920

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M media/base/simd/x86inc.asm View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
agl
9 years, 2 months ago (2011-09-26 19:00:24 UTC) #1
scherkus (not reviewing)
LGTM adding hclam/hbono in case they want to comment
9 years, 2 months ago (2011-09-26 20:52:48 UTC) #2
Hironori Bono
LGTM2. Sorry, I did not notice 32-bit Linux needed PIC code as well as Mac. ...
9 years, 2 months ago (2011-09-27 02:22:18 UTC) #3
Alpha Left Google
I'm curious, is this for the shared library build?
9 years, 2 months ago (2011-09-27 10:24:32 UTC) #4
agl
On Tue, Sep 27, 2011 at 6:24 AM, <hclam@chromium.org> wrote: > I'm curious, is this ...
9 years, 2 months ago (2011-09-27 13:33:00 UTC) #5
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/8046012/1
9 years, 2 months ago (2011-09-27 13:33:54 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-09-27 13:33:56 UTC) #7
Presubmit check for 8046012-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  media/base/simd/x86inc.asm

Powered by Google App Engine
This is Rietveld 408576698