NotificationPromo

chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/new_tab_page_handler.h"
 
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/ui/webui/ntp/new_tab_ui.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/pref_names.h"
 #include "content/common/notification_service.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 static const int kIntroDisplayMax = 10;
 
 // The URL of a knowledge-base article about the new NTP.
 static const char kNTP4IntroURL[] =
   "http://www.google.com/support/chrome/bin/answer.py?answer=95451";
 
 void NewTabPageHandler::RegisterMessages() {
-  web_ui_->RegisterMessageCallback("closePromo", NewCallback(
-      this, &NewTabPageHandler::HandleClosePromo));
+  web_ui_->RegisterMessageCallback("closePromoNotification", NewCallback(
+      this, &NewTabPageHandler::HandleClosePromoNotification));
+  web_ui_->RegisterMessageCallback("promoNotificationViewed", NewCallback(
+      this, &NewTabPageHandler::HandlePromoNotificationViewed));
   web_ui_->RegisterMessageCallback("pageSelected", NewCallback(
       this, &NewTabPageHandler::HandlePageSelected));
   web_ui_->RegisterMessageCallback("introMessageDismissed", NewCallback(
       this, &NewTabPageHandler::HandleIntroMessageDismissed));
   web_ui_->RegisterMessageCallback("introMessageSeen", NewCallback(
       this, &NewTabPageHandler::HandleIntroMessageSeen));
 }
 
-void NewTabPageHandler::HandleClosePromo(const ListValue* args) {
+void NewTabPageHandler::HandleClosePromoNotification(const ListValue* args) {
   Profile::FromWebUI(web_ui_)->GetPrefs()->SetBoolean(prefs::kNTPPromoClosed,
                                                       true);
   NotificationService* service = NotificationService::current();
   service->Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED,
                   Source<NewTabPageHandler>(this),
                   NotificationService::NoDetails());
 }
 
+void NewTabPageHandler::HandlePromoNotificationViewed(const ListValue* args) {
+  PrefService* prefs = Profile::FromWebUI(web_ui_)->GetPrefs();
+  const int views = prefs->GetInteger(prefs::kNTPPromoViews) + 1;
+  prefs->SetInteger(prefs::kNTPPromoViews, views);
+  const int max_views = prefs->GetInteger(prefs::kNTPPromoViewsMax);
+
+  if (views >= max_views) {
+    NotificationService* service = NotificationService::current();
+    service->Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED,
+                    Source<NewTabPageHandler>(this),
+                    NotificationService::NoDetails());
+  }

[Dan Beam, 2011/09/27 03:27:55]

You might consider making this a different notification or sending details to be
able to differentiate this from a re-download of the JSON from the promo service
(and something being changed).  Up to you.

[achuithb, 2011/09/27 08:03:19]

The same notification is sent by the promo_resource_service (which you refer
to), and also when the notification is closed - basically it tells the
ntp_resource_cache to delete the cache. I believe it's correct the way it is.

+}
+
 void NewTabPageHandler::HandlePageSelected(const ListValue* args) {
   double page_id_double;
   CHECK(args->GetDouble(0, &page_id_double));
   int page_id = static_cast<int>(page_id_double);
 
   double index_double;
   CHECK(args->GetDouble(1, &index_double));
   int index = static_cast<int>(index_double);
 
   PrefService* prefs = Profile::FromWebUI(web_ui_)->GetPrefs();
@@ skipping 42 matching lines @@
     values->SetString("ntp4_intro_url", kNTP4IntroURL);
     values->SetString("learn_more",
                       l10n_util::GetStringUTF16(IDS_LEARN_MORE));
   }
 }
 
 // static
 void NewTabPageHandler::DismissIntroMessage(PrefService* prefs) {
   prefs->SetInteger(prefs::kNTP4IntroDisplayCount, kIntroDisplayMax + 1);
 }