Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: my_reviews.py

Issue 8045007: Add distinction for review made by himself. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: my_reviews.py
diff --git a/my_reviews.py b/my_reviews.py
index 1d2377278ee3a9493b56cddcd97cfcd73749720d..47db1da2144f2c8c37306a288e18a315704ca0f1 100755
--- a/my_reviews.py
+++ b/my_reviews.py
@@ -67,12 +67,13 @@ class Stats(object):
self.multiple_lgtms = 0
self.drive_by = 0
self.not_requested = 0
+ self.self_review = 0
self.percent_done = 0.
self.percent_lgtm = 0.
self.percent_drive_by = 0.
self.percent_not_requested = 0.
- self.days = None
+ self.days = 0
self.review_per_day = 0.
self.review_done_per_day = 0.
@@ -168,7 +169,11 @@ def print_issue(issue, reviewer, stats):
"""Process an issue and prints stats about it."""
stats.total += 1
_process_issue(issue)
- if any(msg['sender'] == reviewer for msg in issue['messages']):
+ if issue['owner_email'] == reviewer:
+ stats.self_review += 1
+ latency = '<self review>'
+ reviewed = ''
+ elif any(msg['sender'] == reviewer for msg in issue['messages']):
reviewed = _process_issue_lgtms(issue, reviewer, stats)
latency = _process_issue_latency(issue, reviewer, stats)
else:
@@ -215,8 +220,9 @@ def print_reviews(reviewer, created_after, created_before, instance_url):
stats.finalize(first_day, last_day)
print >> sys.stderr, (
- '%s reviewed %d issues out of %d (%1.1f%%).' %
- (reviewer, stats.actually_reviewed, stats.total, stats.percent_done))
+ '%s reviewed %d issues out of %d (%1.1f%%). %d were self-review.' %
+ (reviewer, stats.actually_reviewed, stats.total, stats.percent_done,
+ stats.self_review))
print >> sys.stderr, (
'%4.1f review request/day during %3d days (%4.1f r/d done).' % (
stats.review_per_day, stats.days, stats.review_done_per_day))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698