Issue 8045001: Update the IDL Generator to use Release instead of Version

Issue 8045001: Update the IDL Generator to use Release instead of Version (Closed)

Created:
9 years, 3 months ago by noelallen1

Modified:
9 years, 2 months ago

Reviewers:
sanga, brettw

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Update the IDL Generator to use Release instead of Version This CL adds the blob_t type for referencing memory pointers. This is a trivial change to idl_c_proto. The man change for this CL is to fix the version mismatch between types in different files. Since each source file can have it's own Label mapping, using the version of one object to index into a version of another can fail between sources. This CL removes the use of version and the LABEL property, and instead converts the Node's version information immediately as it's added into the versioned namespace. Now namespace objects reference via Release (str M14) instead of Version (float 1.0). This allows the Nodes to compare against each other with a global value. 1- Remove lint warning for missing "LABEL" property 2- Convert Version references to Release references such as vmin to rmin, etc... 3- Remove Version interfaces which are no longer needed 4- Move VersionList and VersionMap in namespace to ReleaseList and ReleaseMap in idl_release.py 5- Added tests to idl_release BUG= http://code.google.com/p/chromium/issues/detail?id=97708 TEST= python idl_release && ./generate Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102793

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+353 lines, -451 lines)			Patch
M	ppapi/generators/generator.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/generators/idl_ast.py	View	1	7 chunks	+17 lines, -28 lines	0 comments	Download
M	ppapi/generators/idl_c_proto.py	View		3 chunks	+8 lines, -1 line	0 comments	Download
M	ppapi/generators/idl_generator.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/generators/idl_lint.py	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ppapi/generators/idl_namespace.py	View		9 chunks	+50 lines, -154 lines	0 comments	Download
M	ppapi/generators/idl_node.py	View		8 chunks	+19 lines, -41 lines	0 comments	Download
A +	ppapi/generators/idl_release.py	View		4 chunks	+245 lines, -72 lines	0 comments	Download
D	ppapi/generators/idl_version.py	View		1 chunk	+0 lines, -147 lines	0 comments	Download
M	ppapi/generators/test_cgen/interface.idl	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	ppapi/generators/test_cgen/stdint.idl	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

LGTM http://codereview.chromium.org/8045001/diff/1/ppapi/generators/idl_ast.py File ppapi/generators/idl_ast.py (right): http://codereview.chromium.org/8045001/diff/1/ppapi/generators/idl_ast.py#newcode38 ppapi/generators/idl_ast.py:38: #print '%s%s' % (tab, node) Did you mean ...

9 years, 3 months ago (2011-09-25 06:06:07 UTC) #2

noelallen1

9 years, 2 months ago (2011-09-26 17:01:06 UTC) #4

http://codereview.chromium.org/8045001/diff/1/ppapi/generators/idl_ast.py
File ppapi/generators/idl_ast.py (right):

http://codereview.chromium.org/8045001/diff/1/ppapi/generators/idl_ast.py#new...
ppapi/generators/idl_ast.py:38: #print '%s%s' % (tab, node)
On 2011/09/25 06:06:07, brettw wrote:
> Did you mean to leave this in?

Done.

http://codereview.chromium.org/8045001/diff/1/ppapi/generators/idl_ast.py#new...
ppapi/generators/idl_ast.py:51: # Set version min and max based on properties
On 2011/09/25 06:06:07, brettw wrote:
> Seems like this comment should be indented.

Done.

Expand Messages | Collapse Messages