Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 8044018: Move chrome/browser/ui/touch/keyboard* to chrome/browser/ui/virtual_keyboard/ (Closed)

Created:
9 years, 2 months ago by hashimoto
Modified:
9 years, 2 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, nkostylev+cc_chromium.org, Paweł Hajdan Jr.
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move chrome/browser/ui/touch/keyboard* to chrome/browser/ui/virtual_keyboard/ Move KeyboardManager related files from ui/touch/keyboard to ui/virtual_keyboard Rename KeyboardManager to VirtualKeyboardManager BUG=chromium-os:10620 TEST=chrome and browser_tests compile successfully with GYP_DEFINES="touchui=1" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103050

Patch Set 1 #

Patch Set 2 : Reverted mistakenly made change #

Patch Set 3 : Merged ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -669 lines) Patch
M chrome/browser/chromeos/login/webui_login_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/touch/frame/touch_browser_frame_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/ui/touch/keyboard/keyboard_manager.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/ui/touch/keyboard/keyboard_manager.cc View 1 chunk +0 lines, -491 lines 0 comments Download
D chrome/browser/ui/touch/keyboard/keyboard_manager_browsertest.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M chrome/browser/ui/touch/status_bubble_touch.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.h View 4 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc View 1 4 chunks +11 lines, -10 lines 0 comments Download
A + chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
hashimoto
This CL is a preparation to enable virtual keyboard for non touchUI builds. I changed ...
9 years, 2 months ago (2011-09-26 11:50:27 UTC) #1
sadrul
+bryeung LGTM @hashimoto: Do you have an ETA on when this is planned to be ...
9 years, 2 months ago (2011-09-26 13:55:05 UTC) #2
hashimoto
On 2011/09/26 13:55:05, sadrul wrote: > +bryeung > > LGTM > > @hashimoto: Do you ...
9 years, 2 months ago (2011-09-26 16:46:25 UTC) #3
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/8044018/2001
9 years, 2 months ago (2011-09-26 16:46:58 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager_browsertest.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager_browsertest.cc ...
9 years, 2 months ago (2011-09-26 16:47:05 UTC) #5
sadrul
Please wait for review from bryeung@ before landing.
9 years, 2 months ago (2011-09-26 16:48:37 UTC) #6
hashimoto
On 2011/09/26 16:48:37, sadrul wrote: > Please wait for review from bryeung@ before landing. Sorry, ...
9 years, 2 months ago (2011-09-27 01:43:14 UTC) #7
bryeung
[+mazda, FYI, please keep him in the loop as well] LGTM
9 years, 2 months ago (2011-09-27 17:38:00 UTC) #8
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/8044018/6001
9 years, 2 months ago (2011-09-27 23:27:29 UTC) #9
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager_browsertest.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager_browsertest.cc ...
9 years, 2 months ago (2011-09-27 23:27:37 UTC) #10
M-A Ruel
9 years, 2 months ago (2011-09-28 13:13:31 UTC) #11
On 2011/09/27 23:27:37, I haz the power (commit-bot) wrote:
> Can't apply patch for file

FTR, I'm looking at why it failed. Sorry for the trouble.

Powered by Google App Engine
This is Rietveld 408576698