Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 8044011: Fix speech input keyboard shortcut on Mac OS X.... (Closed)

Created:
9 years, 3 months ago by dmazzoni
Modified:
9 years, 2 months ago
CC:
chromium-reviews, gshires
Visibility:
Public.

Description

Fix speech input keyboard shortcut on Mac OS X. BUG=97902 TEST=manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103765

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/global_keyboard_shortcuts_mac.mm View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/accelerators_cocoa.mm View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dmazzoni
(This never should have been in accelerators_cocoa.mm - I took a guess at where to ...
9 years, 3 months ago (2011-09-24 16:32:17 UTC) #1
dmazzoni
Ping? Can anyone review this?
9 years, 2 months ago (2011-09-30 21:17:12 UTC) #2
pink (ping after 24hrs)
lgtm http://codereview.chromium.org/8044011/diff/1/chrome/browser/global_keyboard_shortcuts_mac.mm File chrome/browser/global_keyboard_shortcuts_mac.mm (right): http://codereview.chromium.org/8044011/diff/1/chrome/browser/global_keyboard_shortcuts_mac.mm#newcode84 chrome/browser/global_keyboard_shortcuts_mac.mm:84: {true, true, false, false, kVK_ANSI_Period, 0, IDC_TOGGLE_SPEECH_INPUT}, 80cols
9 years, 2 months ago (2011-10-03 14:50:37 UTC) #3
Mark Mentovai
LGTM. Sorry ’bout this, I never got the mail ’til today.
9 years, 2 months ago (2011-10-03 15:47:33 UTC) #4
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/8044011/7001
9 years, 2 months ago (2011-10-03 18:31:30 UTC) #5
dmazzoni
No worries...I may have forgotten to send the mail? Anyway, thanks! On Mon, Oct 3, ...
9 years, 2 months ago (2011-10-03 18:32:16 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-10-03 20:03:14 UTC) #7
Change committed as 103765

Powered by Google App Engine
This is Rietveld 408576698