Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: ui/gfx/render_text.h

Issue 8044004: Clean up of SelectionModel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/render_text.cc » ('j') | ui/gfx/render_text.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text.h
===================================================================
--- ui/gfx/render_text.h (revision 103192)
+++ ui/gfx/render_text.h (working copy)
@@ -100,10 +100,6 @@
size_t GetCursorPosition() const;
void SetCursorPosition(size_t position);
- void SetCaretPlacement(SelectionModel::CaretPlacement placement) {
- selection_model_.set_caret_placement(placement);
- }
-
// Moves the cursor left or right. Cursor movement is visual, meaning that
// left and right are relative to screen, not the directionality of the text.
// If |select| is false, the selection start is moved to the same position.
@@ -179,6 +175,10 @@
// Get the logical index of the grapheme following the argument |position|.
virtual size_t GetIndexOfNextGrapheme(size_t position);
+ // Returns the selection model of selection_start_.
msw 2011/09/29 02:20:21 |selection_start_| isn't a member of this class, c
xji 2011/10/03 23:18:57 Done.
+ // The returned value represents a cursor/caret position without a selection.
+ SelectionModel GetSelectionModelForSelectionStart();
+
protected:
RenderText();
@@ -252,10 +252,6 @@
// cursor is within the visible display area.
void UpdateCachedBoundsAndOffset();
- // Returns the selection model of selection_start_.
- // The returned value represents a cursor/caret position without a selection.
- SelectionModel GetSelectionModelForSelectionStart();
-
// Logical UTF-16 string data to be drawn.
string16 text_;
« no previous file with comments | « no previous file | ui/gfx/render_text.cc » ('j') | ui/gfx/render_text.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698