Clean up of SelectionModel

views/controls/textfield/textfield_views_model.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_VIEWS_MODEL_H_
 #define VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_VIEWS_MODEL_H_
 #pragma once
 
 #include <list>
 #include <vector>
@@ skipping 130 matching lines @@
   bool MoveCursorTo(const gfx::SelectionModel& selection);
 
   // Helper function to call MoveCursorTo on the TextfieldViewsModel.
   bool MoveCursorTo(const gfx::Point& point, bool select);
 
   // Selection related method
 
   // Returns the selected text.
   string16 GetSelectedText() const;
 
+  void GetSelectedRange(ui::Range* range) const;

[msw, 2011/10/04 07:25:41]

Please add a simple one line comment, like you have elsewhere:
// Gets the selected range.

[xji, 2011/10/05 01:23:42]

Done.

+
+  // The current composition text will be confirmed. The

[msw, 2011/10/04 07:25:41]

This is 3 lines if you wrap closer to 80 chars:
  // The current composition text will be confirmed. The selection starts with
  // the range's start position, and ends with the range's end position,
  // therefore the cursor position becomes the end position.

[xji, 2011/10/05 01:23:42]

Done.

+  // selection starts with the range's start position,
+  // and ends with the range's end position, therefore
+  // the cursor position becomes the end position.
+  void SelectRange(const ui::Range& range);
+
   void GetSelectionModel(gfx::SelectionModel* sel) const;
 
   // The current composition text will be confirmed.
   // render_text_'s selection model is set to |sel|.
   void SelectSelectionModel(const gfx::SelectionModel& sel);
 
   // Selects all text.
   // The current composition text will be confirmed.
   void SelectAll();
 
@@ skipping 155 matching lines @@
   // 2) new edit is added. (redo history is cleared)
   // 3) redone all undone edits.
   EditHistory::iterator current_edit_;
 
   DISALLOW_COPY_AND_ASSIGN(TextfieldViewsModel);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_VIEWS_MODEL_H_