Clean up of SelectionModel

chrome/browser/ui/views/omnibox/omnibox_view_views.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_
 #pragma once
 
 #include <string>
 
@@ skipping 135 matching lines @@
   // Internally invoked whenever the text changes in some way.
   void TextChanged();
 
   // Update the field with |text| and set the selection.
   void SetTextAndSelectedRange(const string16& text,
                                const ui::Range& range);
 
   // Returns the selected text.
   string16 GetSelectedText() const;
 
+  // Selects the text given by |caret| and |end|.
+  void SelectRange(size_t caret, size_t end);

[msw, 2011/10/04 07:25:41]

Please use |start| to match range and |end|, update comment and impl.
Alternately, take a range like the underlying Textfield::SelectRange.

[xji, 2011/10/05 01:23:42]

removed.

+
   AutocompletePopupView* CreatePopupView(View* location_bar);
 
   views::Textfield* textfield_;
 
   scoped_ptr<AutocompleteEditModel> model_;
   scoped_ptr<AutocompletePopupView> popup_view_;
   AutocompleteEditController* controller_;
   ToolbarModel* toolbar_model_;
 
   // The object that handles additional command functionality exposed on the
@@ skipping 15 matching lines @@
   ui::Range sel_before_change_;
   bool ime_composing_before_change_;
 
   // Was the delete key pressed with an empty selection at the end of the edit?
   bool delete_at_end_pressed_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxViewViews);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_VIEW_VIEWS_H_