Fix a crash when loading a multipart html page.

Fix a crash when loading a multipart html page.

When loading a multipart page, the load hasn't been committed yet so
dataSource() is NULL.  In that case, use the provisionalDataSource().

BUG=97592
TEST=covered by browser_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103027

[tony, 2011-09-23 23:39:32]

The sleep in the python server is a bit sad, but I can't seem to get it to crash
without it.

[tony, 2011-09-26 19:19:47]

+additional reviewer

[abarth-chromium, 2011-09-26 20:06:31]

lgtm

[commit-bot: I haz the power, 2011-09-26 22:55:47]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/8044003/1001

[commit-bot: I haz the power, 2011-09-26 22:55:50]

Presubmit check for 8044003-1001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: net/tools/testserver/testserver.py

Presubmit checks took 1.6s to calculate.

[tony, 2011-09-26 23:00:42]

+some net owners

(maybe net/tools should have an OWNERS file with *?)

[eroman, 2011-09-27 00:56:41]

LGTM

http://codereview.chromium.org/8044003/diff/1001/net/tools/testserver/testser...
File net/tools/testserver/testserver.py (right):

http://codereview.chromium.org/8044003/diff/1001/net/tools/testserver/testser...
net/tools/testserver/testserver.py:1318: test_name = "/multipart-slow"
nit: for consistency use single quotemarks throughout.

[commit-bot: I haz the power, 2011-09-27 02:04:25]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/8044003/9001

[commit-bot: I haz the power, 2011-09-27 03:27:34]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 102850, job name
was 8044003-9001 (retry) (retry) (retry) (retry).

[Aaron Boodman, 2011-09-27 06:00:47]

http://codereview.chromium.org/8044003/diff/9001/chrome/renderer/extensions/u...
File chrome/renderer/extensions/user_script_slave.cc (right):

http://codereview.chromium.org/8044003/diff/9001/chrome/renderer/extensions/u...
chrome/renderer/extensions/user_script_slave.cc:244: DCHECK(data_source);
You should CHECK this. If NULL, it will crash soon anyway, so we might as well
have a clear indication of the problem in the crash report.

[Aaron Boodman, 2011-09-27 06:02:14]

Also, can we just always use provisionalDataSource(). Does it go away once
committed?

[tony, 2011-09-27 18:54:14]

On 2011/09/27 06:00:47, Aaron Boodman wrote:
>
http://codereview.chromium.org/8044003/diff/9001/chrome/renderer/extensions/u...
> File chrome/renderer/extensions/user_script_slave.cc (right):
> 
>
http://codereview.chromium.org/8044003/diff/9001/chrome/renderer/extensions/u...
> chrome/renderer/extensions/user_script_slave.cc:244: DCHECK(data_source);
> You should CHECK this. If NULL, it will crash soon anyway, so we might as well
> have a clear indication of the problem in the crash report.

Done.


On 2011/09/27 06:02:14, Aaron Boodman wrote:
> Also, can we just always use provisionalDataSource(). Does it go away once
> committed?

It goes away once committed.

[commit-bot: I haz the power, 2011-09-27 20:25:13]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/tony@chromium.org/8044003/7003

[commit-bot: I haz the power, 2011-09-27 22:13:51]

Change committed as 103027