Issue 8043029: Protect predictor_ shutdown in PrifileImplIoData::Handle destructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8043029: Protect predictor_ shutdown in PrifileImplIoData::Handle destructor (Closed)

Created:
9 years, 2 months ago by stevenjb

Modified:
9 years, 2 months ago

Reviewers:
rpetterson, DaveMoore, willchan no longer on Chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Protect predictor_ shutdown in PrifileImplIoData::Handle destructor BUG=chromium-os:20407 TEST=Run browser tests and watch for crashes in shutdown (see issue) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102825

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/browser/profiles/profile_impl_io_data.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

9 years, 2 months ago (2011-09-26 21:24:26 UTC) #4

LGTM

Wow, I didn't know that OnFinalInit() got postponed to finish asynchronously. I
don't know what I think about that. Anyway, this fix looks good.

Expand Messages | Collapse Messages