Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 8043029: Protect predictor_ shutdown in PrifileImplIoData::Handle destructor (Closed)

Created:
9 years, 2 months ago by stevenjb
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Protect predictor_ shutdown in PrifileImplIoData::Handle destructor BUG=chromium-os:20407 TEST=Run browser tests and watch for crashes in shutdown (see issue) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stevenjb
9 years, 2 months ago (2011-09-26 18:42:00 UTC) #1
rpetterson
LGTM
9 years, 2 months ago (2011-09-26 18:52:07 UTC) #2
stevenjb
+ davemoore@chromium.org for OWNER
9 years, 2 months ago (2011-09-26 21:19:20 UTC) #3
willchan no longer on Chromium
9 years, 2 months ago (2011-09-26 21:24:26 UTC) #4
LGTM

Wow, I didn't know that OnFinalInit() got postponed to finish asynchronously. I
don't know what I think about that. Anyway, this fix looks good.

Powered by Google App Engine
This is Rietveld 408576698