Issue 8043027: AutofillMergeTest doesn't need scoped_ptr for PersonalDataManager mock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8043027: AutofillMergeTest doesn't need scoped_ptr for PersonalDataManager mock (Closed)

Created:
9 years, 2 months ago by dhollowa

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, Ilya Sherman

CC:
chromium-reviews, GeorgeY, Paweł Hajdan Jr., Ilya Sherman, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

AutofillMergeTest doesn't need scoped_ptr for PersonalDataManager mock Changes AutofillMergeTest fixture from using a scoped_ptr<PersonalDataManagerMock> to direct PersonalDataManagerMock member. BUG=94026 TEST=AutofillMergeTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102808

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	chrome/browser/autofill/autofill_merge_unittest.cc	View		4 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/dhollowa@chromium.org/8043027/1

9 years, 2 months ago (2011-09-26 20:16:17 UTC) #3

Change committed as 102808

Expand Messages | Collapse Messages