mac: Support "Use Selection for Find" when omnibox is focused.

mac: Support "Use Selection for Find" when omnibox is focused.

BUG=96625
TEST=Select text in omnibox, hit cmd-e cmd-g. Selected text should
appear in find box. Focus omnibox, don't select anything, hit cmd-e.
Should beep.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102658

[Nico, 2011-09-24 06:12:42]

First reviewer wins.

[Avi (use Gerrit), 2011-09-24 11:45:04]

http://codereview.chromium.org/8043015/diff/1/chrome/browser/ui/cocoa/locatio...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
(right):

http://codereview.chromium.org/8043015/diff/1/chrome/browser/ui/cocoa/locatio...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm:479:
return YES;
return [super validateMenuItem:item]? Otherwise comment why as that's what would
be expected.

[Scott Hess - ex-Googler, 2011-09-24 15:37:27]

LGTM

I agree with Avi's comment.

I wonder if there are other places this needs to apply, like in the findbar
(sub-selection), or about panels.  I guess we don't have tons of places with
selectable text fields, though.

http://codereview.chromium.org/8043015/diff/1/chrome/browser/ui/cocoa/locatio...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm
(right):

http://codereview.chromium.org/8043015/diff/1/chrome/browser/ui/cocoa/locatio...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm:492:
[[FindPasteboard sharedInstance] setFindText:[selection string]];
There are times I find myself not entirely convinced by our pasteboard code ...

[commit-bot: I haz the power, 2011-09-24 16:42:08]

CQ is trying tha patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8043015/3002

[Nico, 2011-09-24 16:42:14]

Done. Thanks, guys!

[commit-bot: I haz the power, 2011-09-24 17:53:45]

Change committed as 102658