Issue 8043004: Disable bookmark pane in ntp4.

Issue 8043004: Disable bookmark pane in ntp4. (Closed)

Created:
9 years, 2 months ago by Evan Stade

Modified:
9 years, 2 months ago

Reviewers:
csilv

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Disable bookmark pane in ntp4. BUG=98070 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102774

Patch Set 2 : some half arsed css #

Total comments: 1

Patch Set 4 : update updateSliderCards #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
M	chrome/browser/resources/ntp4/new_tab.css	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.js	View	1 2 3	3 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_ui.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csilv

http://codereview.chromium.org/8043004/diff/2001/chrome/browser/resources/ntp4/new_tab.css File chrome/browser/resources/ntp4/new_tab.css (right): http://codereview.chromium.org/8043004/diff/2001/chrome/browser/resources/ntp4/new_tab.css#newcode228 chrome/browser/resources/ntp4/new_tab.css:228: html[dir=ltr] #page-switcher-start, Are these supposed to be part of ...

9 years, 2 months ago (2011-09-23 23:29:19 UTC) #1

csilv

LGTM. I'm going to do further testing with this after my flight if you want ...

9 years, 2 months ago (2011-09-23 23:58:38 UTC) #2

Evan Stade

just need it by Monday. I'll wait for the feedback. I banged around a bit ...

9 years, 2 months ago (2011-09-24 00:09:14 UTC) #3

csilv

LGTM with one change below: http://codereview.chromium.org/8043004/diff/5001/chrome/browser/resources/ntp4/new_tab.js File chrome/browser/resources/ntp4/new_tab.js (right): http://codereview.chromium.org/8043004/diff/5001/chrome/browser/resources/ntp4/new_tab.js#newcode456 chrome/browser/resources/ntp4/new_tab.js:456: case templateData['bookmarks_page_id']: Need to ...

9 years, 2 months ago (2011-09-26 17:10:56 UTC) #4

Evan Stade

9 years, 2 months ago (2011-09-26 18:50:24 UTC) #5

http://codereview.chromium.org/8043004/diff/5001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/8043004/diff/5001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/new_tab.js:456: case
templateData['bookmarks_page_id']:
On 2011/09/26 17:10:57, csilv wrote:
> Need to comment out 456-458.

yea, I thought about this while riding my bicycle. I've more or less done as you
said.

Expand Messages | Collapse Messages