Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 8041033: Changed Mac, Linux and Win Official Chrome build to drop default app CRXs in (Closed)

Created:
9 years, 2 months ago by Roger Tawa OOO till Jul 10th
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Changed Mac, Linux and Win Official Chrome build to drop default app CRXs in the build/installer output. This change undoes the revert of 99878. This change was originally reverted because it was decided to push this change to M16. BUG=94920 TEST=Do an Official build in mac, linux and win. Ensure that after installing the app, you can find the default apps under the install's directory structure. For win, this is under a default_apps directory, for mac, this is under a "Default Apps" directory. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103078

Patch Set 1 #

Patch Set 2 : Addressing review comments, adding missing file #

Total comments: 2

Patch Set 3 : Added descriptive comment to json file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M build/common.gypi View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/browser/resources/default_apps/external_extensions.json View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Roger Tawa OOO till Jul 10th
9 years, 2 months ago (2011-09-26 19:14:11 UTC) #1
robertshield
On 2011/09/26 19:14:11, Roger Tawa wrote: Windows portion LGTM. For maintainability, you might want to ...
9 years, 2 months ago (2011-09-26 19:44:09 UTC) #2
Mark Mentovai
LGTM
9 years, 2 months ago (2011-09-26 19:46:47 UTC) #3
Michael Moss
LGTM
9 years, 2 months ago (2011-09-27 15:46:28 UTC) #4
Roger Tawa OOO till Jul 10th
Thanks for the tip Robert. In fact, it made me realize I had forgotten a ...
9 years, 2 months ago (2011-09-27 18:49:32 UTC) #5
robertshield
LGTM http://codereview.chromium.org/8041033/diff/5001/chrome/browser/resources/default_apps/external_extensions.json File chrome/browser/resources/default_apps/external_extensions.json (right): http://codereview.chromium.org/8041033/diff/5001/chrome/browser/resources/default_apps/external_extensions.json#newcode2 chrome/browser/resources/default_apps/external_extensions.json:2: "blpcfgokakmgnkcojhhkbfbldkacnbeo" : { perhaps a comment here explaining ...
9 years, 2 months ago (2011-09-27 20:07:14 UTC) #6
Roger Tawa OOO till Jul 10th
9 years, 2 months ago (2011-09-27 20:57:30 UTC) #7
Thanks Robert.

http://codereview.chromium.org/8041033/diff/5001/chrome/browser/resources/def...
File chrome/browser/resources/default_apps/external_extensions.json (right):

http://codereview.chromium.org/8041033/diff/5001/chrome/browser/resources/def...
chrome/browser/resources/default_apps/external_extensions.json:2:
"blpcfgokakmgnkcojhhkbfbldkacnbeo" : {
On 2011/09/27 20:07:14, robertshield wrote:
> perhaps a comment here explaining what this file is?

I don't think comments are used in external_extensions.json, but if they are
I'll add some.  This file maps extension ids to the relative path (relative to
this file) to the crx that implements that extension.

Powered by Google App Engine
This is Rietveld 408576698