Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 8041015: Make the RegExp.prototype object be a RegExp object. (Closed)

Created:
9 years, 3 months ago by Lasse Reichstein
Modified:
9 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Make the RegExp.prototype object be a RegExp object. BUG=v8:1217 TEST=mjsunit/regress/regress-1217 Committed: http://code.google.com/p/v8/source/detail?r=9419

Patch Set 1 #

Patch Set 2 : Inadvertent edit. #

Patch Set 3 : Updated test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -59 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M src/regexp.js View 4 chunks +7 lines, -4 lines 0 comments Download
M test/es5conform/es5conform.status View 1 2 2 chunks +0 lines, -19 lines 0 comments Download
D test/mjsunit/bugs/bug-1217.js View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
A + test/mjsunit/regress/regress-1217.js View 1 2 1 chunk +22 lines, -4 lines 0 comments Download
M test/sputnik/sputnik.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
I've had half a fix for this lying around for a while. And JSC has ...
9 years, 3 months ago (2011-09-26 08:30:44 UTC) #1
Yang
9 years, 3 months ago (2011-09-26 08:39:43 UTC) #2
On 2011/09/26 08:30:44, Lasse Reichstein wrote:
> I've had half a fix for this lying around for a while. 
> And JSC has changed this already, so our comments about JSC compatibility were
> outdated.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698