Issue 8039: - ip register cannot be used when accessing large constants in the instructio...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8039: - ip register cannot be used when accessing large constants in the instructio... (Closed)

Created:
12 years, 2 months ago by iposva

Modified:
9 years, 4 months ago

Reviewers:
Feng Qian

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- ip register cannot be used when accessing large constants in the instruction stream. Enhance the debug code to save and restore the unused holder_reg at these points. - Fix lint issues. Committed: http://code.google.com/p/v8/source/detail?r=545

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -9 lines)			Patch
M	src/bootstrapper.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/macro-assembler-arm.cc	View	1	3 chunks	+19 lines, -7 lines	0 comments	Download
M	src/macro-assembler-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Feng Qian

12 years, 2 months ago (2008-10-21 22:35:48 UTC) #2

LGTM overall,

The push/pop between null check and global_context_map check can be eliminated.

http://codereview.chromium.org/8039/diff/1/4
File src/macro-assembler-arm.cc (right):

http://codereview.chromium.org/8039/diff/1/4#newcode698
Line 698: mov(ip, holder_reg);  // Restore ip.
Restore ip in the middle seems unnecessary because Check failure halts
execution. Something simpler:
  push(holder_reg);
  mov(hodler_reg, ip);
  cmp(holder_reg, ... null_value() ... );
  Check

  ldr(holder_reg, FieldMemOperand(holder_reg, HeapObject::kMapOffset);
  cmp(holder_reg, ... global_context_map() ...);
  Check(...);

  pop(holder_reg);
  ldr(ip, FieldMemOperand(holder_reg, ...));

what do you think?

Expand Messages | Collapse Messages