chrome/browser/autofill/contact_info.cc - Issue 8038064: Autofill: Support 'full names' that are lacking a first or a middle name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/contact_info.cc

Issue 8038064: Autofill: Support 'full names' that are lacking a first or a middle name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/contact_info.h ('k') | chrome/browser/autofill/contact_info_unittest.cc » ('j') | chrome/browser/autofill/contact_info_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/contact_info.cc

diff --git a/chrome/browser/autofill/contact_info.cc b/chrome/browser/autofill/contact_info.cc

index c7a4b77f38c3d9dee63f3acdad1eefb04c4f6060..c3a92d83553d72b9a54e9e2e9649cce7d562e7c0 100644

--- a/chrome/browser/autofill/contact_info.cc

+++ b/chrome/browser/autofill/contact_info.cc

@@ -84,11 +84,9 @@ void NameInfo::SetInfo(AutofillFieldType type, const string16& value) {

}

string16 NameInfo::FullName() const {

- if (first_.empty())

- return string16();

std::vector<string16> full_name;

- full_name.push_back(first_);

+ if (!first_.empty())

+ full_name.push_back(first_);

if (!middle_.empty())

full_name.push_back(middle_);