Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 8038064: Autofill: Support 'full names' that are lacking a first or a middle name. (Closed)

Created:
9 years, 2 months ago by Ilya Sherman
Modified:
9 years, 2 months ago
CC:
chromium-reviews, GeorgeY, Paweł Hajdan Jr., Ilya Sherman, dyu1, dhollowa
Visibility:
Public.

Description

Autofill: Support 'full names' that are lacking a first or a middle name. BUG=98335 TEST=unit_tests --gtest_filter=NameInfoTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103241

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove extra space #

Patch Set 3 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -37 lines) Patch
M chrome/browser/autofill/autofill_profile_unittest.cc View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/autofill/contact_info.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/autofill/contact_info.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/autofill/contact_info_unittest.cc View 1 1 chunk +86 lines, -25 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ilya Sherman
9 years, 2 months ago (2011-09-28 21:57:25 UTC) #1
dhollowa
LGTM. http://codereview.chromium.org/8038064/diff/1/chrome/browser/autofill/contact_info_unittest.cc File chrome/browser/autofill/contact_info_unittest.cc (right): http://codereview.chromium.org/8038064/diff/1/chrome/browser/autofill/contact_info_unittest.cc#newcode101 chrome/browser/autofill/contact_info_unittest.cc:101: nit: extra space.
9 years, 2 months ago (2011-09-28 22:02:43 UTC) #2
Ilya Sherman
http://codereview.chromium.org/8038064/diff/1/chrome/browser/autofill/contact_info_unittest.cc File chrome/browser/autofill/contact_info_unittest.cc (right): http://codereview.chromium.org/8038064/diff/1/chrome/browser/autofill/contact_info_unittest.cc#newcode101 chrome/browser/autofill/contact_info_unittest.cc:101: On 2011/09/28 22:02:43, dhollowa wrote: > nit: extra space. ...
9 years, 2 months ago (2011-09-28 22:03:38 UTC) #3
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8038064/5001
9 years, 2 months ago (2011-09-28 22:03:51 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years, 2 months ago (2011-09-29 00:05:45 UTC) #5
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/8038064/3002
9 years, 2 months ago (2011-09-29 02:29:45 UTC) #6
commit-bot: I haz the power
9 years, 2 months ago (2011-09-29 05:29:06 UTC) #7
Change committed as 103241

Powered by Google App Engine
This is Rietveld 408576698