Issue 8038051: Fix build with Heimdal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8038051: Fix build with Heimdal. (Closed)

Created:
9 years, 2 months ago by Paweł Hajdan Jr.

Modified:
9 years, 2 months ago

Reviewers:
cbentzel, asanka

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix build with Heimdal. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103369

Patch Set 1 #

Patch Set 2 : fix #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	net/http/http_auth_gssapi_posix.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

cbentzel

Adding asanka - he's done development on the Heimdal package and may have more insight.

9 years, 2 months ago (2011-09-28 17:13:49 UTC) #2

cbentzel

And LGTM - this seems fine, but I just want asanka's feedback.

9 years, 2 months ago (2011-09-28 17:27:21 UTC) #3

asanka

Quick question: Wouldn't this cause problems when we have DLOPEN_KERBEROS?

9 years, 2 months ago (2011-09-28 18:47:30 UTC) #4

Paweł Hajdan Jr.

Bleh, the previous version was failing to compile. PTAL The try jobs run with DLOPEN_KERBEROS, ...

9 years, 2 months ago (2011-09-29 20:46:24 UTC) #5

asanka

9 years, 2 months ago (2011-09-29 21:10:38 UTC) #6

LGTM.

The problem with using Heimdal's symbols (patchset 1 approach) is that it
creates a static dependency on the Heimdal shared library.  This could cause
problems when building with DLOPEN_KERBEROS if we try to dlopen() a different
Kerberos library.

Since we want these OIDs to be defined locally, maybe we could consider giving
them names that don't conflict with gssapi.h.

Expand Messages | Collapse Messages