Issue 8038046: Fixing test case from r9469.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8038046: Fixing test case from r9469. (Closed)

Created:
9 years, 2 months ago by Yang

Modified:
9 years, 2 months ago

Reviewers:
Søren Thygesen Gjesse, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fixing test case from r9469. Committed: http://code.google.com/p/v8/source/detail?r=9473

Patch Set 1 #

Patch Set 2 : . #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -26 lines)			Patch
	M	test/cctest/test-debug.cc	View	1	2 chunks	+0 lines, -24 lines	0 comments	Download
	M	test/cctest/test-threads.cc	View	1	3 chunks	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

The test case for the debugger deadlock led unexpectedly to test failures on the buildbots ...

9 years, 2 months ago (2011-09-28 14:18:33 UTC) #1

Søren Thygesen Gjesse

9 years, 2 months ago (2011-09-29 08:17:36 UTC) #3

LGTM

Was the failures related to TCP/IP ports being in use? If so we should consider
to rewrite all tests using sockets to use system assigned ports. Passing port 0
to listen will make the system assign a free port which can be retrieved using
getsockname (on all platforms I think) and used by the rest of the test.

Expand Messages | Collapse Messages