Issue 8038043: Split touch and HiDPI newtab icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8038043: Split touch and HiDPI newtab icons (Closed)

Created:
9 years, 2 months ago by sail1

Modified:
9 years, 2 months ago

Reviewers:
Lei Zhang, sail, Emmanuel Saint-loubert-Bié

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Split touch and HiDPI newtab icons Currently we have two sets of newtab icons, standard and large. The large set is used on the Mac in HiDPI mode and also in the touchui. In r99262 we changed the large icons to look better on touchui but this ended up looking bad on the Mac. This changes fixes the problem by putting the touch version of the newtab icon in a separate set for now. We're working on a better naming scheme to avoid problems like this in the future. BUG=96009 TEST=

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, --4 lines)			Patch
M	chrome/app/theme/large_newtab.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/large_newtab_button_mask.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/large_newtab_h.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/large_newtab_p.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/newtab.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/newtab_button_mask.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/newtab_h.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/newtab_p.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/theme_resources_large.grd	View	1 chunk	+12 lines, -4 lines	0 comments	Download
A +	chrome/app/theme/touch_newtab.png	View	Binary file		0 comments	Download
A +	chrome/app/theme/touch_newtab_button_mask.png	View	Binary file		0 comments	Download
A +	chrome/app/theme/touch_newtab_h.png	View	Binary file		0 comments	Download
A +	chrome/app/theme/touch_newtab_p.png	View	Binary file		0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sail

You can't see the icons in the review page so I've attached the icons to ...

9 years, 2 months ago (2011-09-27 00:17:58 UTC) #1

Emmanuel Saint-loubert-Bié

I am not too excited to have large == HiDPI I hope that we will ...

9 years, 2 months ago (2011-09-27 00:20:15 UTC) #2

sail

9 years, 2 months ago (2011-09-27 00:21:57 UTC) #3

On 2011/09/27 00:20:15, Emmanuel Saint-loubert wrote:
> I am not too excited to have large == HiDPI

Yea, the touch_ prefix is temporary.

Expand Messages | Collapse Messages